History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: CIB-1698
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: 3 3
Assignee: Daniel Ostermeier
Reporter: Daniel Ostermeier
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Pulse

No ScmContext available during create project wizard, meaning no scmContext available for the browse request.

Created: 31/Oct/08 01:52 AM   Updated: 11/Nov/08 01:10 PM
Return to search
Component/s: None
Affects Version/s: 2.0.10
Fix Version/s: 2.0.15

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown


 Description  « Hide
I have created this issue to that we can close off the review and deal with this separately.

--------
We have a problem: during the project wizard there is no way to make your context. There is likely another problem too: browsing is meant to be fast, so relying on a local persistent checkout to do it may not work so well?
Daniel Ostermeier 4 weeks, 1 day ago (October 1st, 2008, 2:54 a.m.)
Well that is a problem, since there are no alternatives that I have found :(. Will take this out of this review and add it to http://jira.zutubi.com/browse/CIB-1662
Jason Sankey 4 weeks, 1 day ago (October 1st, 2008, 10:51 a.m.)
Maybe browse shouldn't get a context, or maybe we just document that it may be null. Either way the restrictions on browse need to be well documented. At least it is bonus functionality rather than required.
Daniel Ostermeier 1 week, 1 day ago (October 22nd, 2008, 10:04 p.m.)
The awkwardness is that we then need to be able to recognize if browse is not available if the ScmContext is null. We would rather not show the browse link rather than returning nothing after all.
Allowing the capabilities to change based on the context would resolve this. IE: during the wizard, getCapabilities(null) would not return the BROWSE capability since Git can not browse without a context. How does that sound?.
Jason Sankey 1 week, 1 day ago (October 22nd, 2008, 11:59 p.m.)
The general idea is appealing, I am just unsure of the consequences of this. Can we pass a context everywhere we check capabilities? Do contexts change over time, meaning we would have to check capabilities more often? Would this make any cases awkward, where it is possible for an SCM to be capable at one point in time but not later? Maybe I am worried about nothing, I haven't reviewed the use of capabilities. If there are problems, though, I am happy enough to just say browsing gets no context for now, as it is not a critical operation at all.

 All   Comments   Work Log   Change History      Sort Order:
jason - 08/Nov/08 02:05 AM
Maybe we should make it getCapabilities(boolean contextAvailable). Passing a context to getCapabilities makes little sense to test the case where we have no context available -- because we have no context to pass!

Daniel Ostermeier - 11/Nov/08 01:10 PM
resolved in revision 5117 pending review